Re: toolchain/39528: src/tools/file fails to install due to permission problem

[Alan Barrett <apb%cequrux.com@localhost>]

On Wed, 08 Oct 2008, Izumi Tsutsui wrote:
> > >Description:
> > On build.sh tools, "make install" in src/tools/files invokes
> > "src/dist/file/install-sh" script directly for "MKDIR_P"
> > (at least on NetBSD/i386 4.99.72 host).

That's a bug; any shell scripts run during the build should explicitly
use "${HOST_SH} scriptname args..." (or equivalent).

> Is it okay to commit this workaround for builds with source tar sets?
> If there is no objection, I'll commit this in this weekend.
> 
> > --- dist/file/configure     30 Aug 2008 12:16:51 -0000      1.19
> > +++ dist/file/configure     13 Sep 2008 01:38:54 -0000
> > @@ -2159,7 +2159,7 @@
> >      # break other packages using the cache if that directory is
> >      # removed, or if the value is a relative name.
> >      test -d ./--version && rmdir ./--version
> > -    MKDIR_P="$ac_install_sh -d"
> > +    MKDIR_P="\$(SHELL) $ac_install_sh -d"
> >    fi
> >  fi

That looks reasonable, since ${SHELL} is set to ${CONFIG_SHELL} by
the configure script, and ${CONFIG_SHELL} is set to ${HOST_SH} by
build.sh.  However, perhaps it would be better to modify the definition
of ac_install_sh instead of modifying the definition of MKDIR_P?

--apb (Alan Barrett)