Re: inconsistent freetype2/fontconfig/libXft

[David Holland <dholland-pkgtech%netbsd.org@localhost>]

On Sat, Oct 31, 2026 at 08:56:24PM -0400, Greg Troxel wrote:
 > 
 > David Holland <dholland-pkgtech%netbsd.org@localhost> writes:
 > 
 > > See PR 57517 for further details. Summary: BUILDLINK_PREFIX can
 > > (sometimes?) get set before the logic that handles transitive
 > > USE_BUILTIN=no, and if it does, the wrong files get buildlinked.
 > 
 > This is hard to follow for me, but I did.   I therefore expect, perhaps
 > unfairly that many others will have the same sorts of difficulties.  So
 > I think it's fine to commit your fix, but I'd like either a pointer  to
 > the PR, or an explanation perhaps
 > 
 >   This package, on its own, is chosen as builtin.  Because some package
 >   that it depends on is chosen as pkgsrc, it must also be forced to
 >   pkgsrc.  Clear the prefix, because otherwise the later logic to set
 >   the prefix to pkgsrc will fail.
 > 
 > and if I got it wrong and you fix it to be better, that's fine with me.

How's
         # If the buildlink prefix is already set, it is pointing to
         # the builtin version. Clear it; otherwise the buildlink
         # logic will blindly use it and we'll buildlink the builtin
         # version regardless of the USE_BUILTIN setting, and then
         # things break. XXX: this is a hack.

?

There's another comment above the loop that explains what the whole
thing is doing; if that's not good enough, it should be improved too.

(I wrote the whole thing some years back and there's a decent chance
I'm the only person who understands it :-| )

-- 
David A. Holland
dholland%netbsd.org@localhost