tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Patch for graphics/lcms2 (alignment issues on sparc)



Taylor R Campbell <riastradh%NetBSD.org@localhost> writes:

>> Date: Sat, 31 Oct 2026 14:24:04 -0400
>> From: vom513 <vom513%gmail.com@localhost>
>> 
>> +# lcms2's suballocator defaults to sizeof(void *) alignment; 32-bit SPARC
>> +# needs 8 for doubles (Ghostscript's bundled lcms2mt already does this).
>> +.if ${MACHINE_ARCH} == "sparc"
>> +CPPFLAGS+=	-DCMS_PTR_ALIGNMENT=8
>
> Maybe this should be alignof(max_align_t) instead?  I expect this
> affects more than just sparc32.

In this case, we really need to know the alignment for doubles, as I
understand it.  Having some other type with even biggger alignment would
cause max_align_t to be bigger, and that would be wasteful.

Anyone with a retro arch that needs more then 4 for doubles, please
speak up.


Home | Main Index | Thread Index | Old Index