Re: editors/nvi patch checksum errors on macOS with UTF-8 locale

[Greg Troxel <gdt%lexort.com@localhost>]

Edgar Fuß <ef%math.uni-bonn.de@localhost> writes:

> When trying to build editors/nvi from 2026Q3 on macOS (15) I get checksum 
> errors on patches/patch-a[d-g] when using a UTF-8 locale.
> I don't get these on NetBSD (11).

I see the same thing, on macOS 15 on an x86-65 imac.

Looking at the patch files, they have non-ASCII bytes.  Examining
patch-ad with emacs, I see what seem like Chinese characters in the
middle of a string which is obviously in French, where I expect é.  The
(unicode) character in the file is 0x99d1 and that doesn't make sense to
me.  Using ´od -c´, I see that the byte is 0351, which is
iso-8859-? for é.

So this is 8859/utf8 confusion.  The nvi sources are in 8859, not utf-8.

The real mystery is why 'digest sha1' would differ, as I think of SHA-1
as operating on byte streams.  I am guessing it is using some interface
that on apple turns into wide characters and apple does utf-8 decoding.
If so that's a bug; I think SHA-1 computation is about octets, not
characters.