Wrappers dropping gcc/clang -w

[Jonathan Perkin <jperkin%pkgsrc.org@localhost>]

Back in 2007 Roland added this to the legacy shell wrappers:

  # There are some packages suppressing all warnings. We don't want that.
  -w                     ) transform_discard ;;

cwrappers copied it verbatim:

  { "-w", 2, transform_discard, NULL },

making it the only argument other than "-mt" which is explicitly dropped 
with prejudice by either wrapper implementation.

I'm currently packaging ClickHouse, which is an .. interesting build, 
and it uses -w to ignore warnings from all of the third-party bundled 
software it builds.  Patching them all is untenable.

There is a *lot* wrong with ClickHouse, but I'm not sure I entirely 
agree that us dropping -w is correct.  I'm currently having to hack 
around it by adding back:

  CWRAPPERS_APPEND.cc+=   -Wno-everything
  CWRAPPERS_APPEND.cxx+=  -Wno-everything

I'd be interested in others thoughts here.  I intensely dislike magic, 
and this feels very much like us poking our nose in where it doesn't 
belong, or should at least be some mk.conf option to enable extra 
BUILDLINK_TRANSFORM for people who want to do builds that enforce 
stricter environments than the software they are building do themselves.

--
Jonathan Perkin                    pkgsrc.smartos.org
Open Source Complete Cloud   www.tritondatacenter.com