python, expat

[Greg Troxel <gdt%lexort.com@localhost>]

[I previously wrote about expat on macOS, but the problem turned out to
be a that macOS is buggy.   It is documented that Command Line Tools are
updated by Software Update, but they aren't.  Removing them and
code-select --install got me newer bits and pkgsrc is ok with those.]


I just ran into qgis crashing on startup, in python expat.

In lang/python313, there is

  .if ${OPSYS} == NetBSD && ${OPSYS_VERSION} < 119905
  PREFER.expat=  pkgsrc # needs expat_config.h
  .endif

However, netbsd-10 has expat_config.h, mod date in 2022.

python313 builds fine with that conditional adjusted to "before 10"
(netbsd-9 lacks expat_config.h).

After "make replace", qgis runs fine.

I am suspicious of the python build -I ordering and if it gets a
consistent view of one expat or the other.

So, I think we should commit a change (with PKGREVISION++) to all the
python versions that have this stanza.

Alternatively, Adam could commit adding expat_config.h for builtin
detection.  But, I made that change locally and it didn't work - old
expat was still accepted.

What do people who understand python/expat better think?


Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/lang/python313/Makefile,v
retrieving revision 1.32
diff -u -p -r1.32 Makefile
--- Makefile	25 Mar 2026 22:52:08 -0000	1.32
+++ Makefile	20 Jun 2026 17:10:49 -0000
@@ -227,7 +227,7 @@ CONFIGURE_ENV+=		ac_cv_lib_intl_textdoma
 .include "../../devel/zlib/buildlink3.mk"
 .include "../../security/openssl/buildlink3.mk"
 .include "../../math/mpdecimal/buildlink3.mk"
-.if ${OPSYS} == NetBSD && ${OPSYS_VERSION} < 119905
+.if ${OPSYS} == NetBSD && ${OPSYS_VERSION} < 100000
 PREFER.expat=	pkgsrc # needs expat_config.h
 .endif
 .include "../../textproc/expat/buildlink3.mk"