tech-pkg archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: bsd.prefs.mk OpenIndiana detection
On Mon, 13 Apr 2026 09:10:58 +0100
Jonathan Perkin <jperkin%pkgsrc.org@localhost> wrote:
> * On 2026-04-13 at 09:01 BST, Tobias Nygren wrote:
>
> >I'd like to commit this patch to be able to fix some PLIST issues
> >on OpenIndiana. pkgsrc currently detects OpenIndiana as Solaris
> >instead of Illumos which breaks some packages like lang/go.
>
> Parsing /etc/release always feels incredibly fragile to me, but I guess
> these distributions don't provide a better way to identify themselves,
> so the approach is probably ok for now.
Yep, considering there is prior art for the other supported distros.
> However this section should really have the ability to cache
> NATIVE_OS_VARIANT and NATIVE_LOWER_VARIANT_VERSION if you don't want
> performance to suck, especially for bulk scans.
Scan for meta-pkgs/bulk-medium:
- real 3m28.593s
+ real 3m39.615s
While measurably worse it's not significant enough for me to pursue so
I'll commit as-is and leave the caching logic for someone else to
figure out as it doesn't affect the already supported cases.
-Tobias
Home |
Main Index |
Thread Index |
Old Index