Re: cairo: xcb implies x11

[Greg Troxel <gdt%lexort.com@localhost>]

Thomas Klausner <wiz%netbsd.org@localhost> writes:

> The cairo package has an xcb option. When it's enabled, it also
> does everything the x11 option does.
>
> This is a problem if you want to turn off x11 with '-x11' in the
> options - if you don't turn off xcb as well, nothing happens.
>
> I'm not quite sure why xcb even is a separate option. So here are
> proposals:
>
> 1. Merge the xcb option into the x11 option (effectively removing it),
>
> or
>
> 2. Make it an error to enable the xcb option while the x11 option is
>    disabled.

Reading DESCR for libxcb, it's an alternative implementation for Xlib.
So..

  1) If that makes sense, we should treat it like JPEG_DEFAULT.  But
  that's hard, and not reasonable to be in the path to fix this.

  2) The intent of the option is "use libxcb instead of normal xlib".
  Therefore either
     a) if x11 is not enabled, pay no attention to the xcb option
     b) if x11 is not enabled, and xcb is, error out

I lean to 2a, but if people that want to use xcb with cairo like 2b
better, they can have it.

Your choice 1 has to either say "always xcb" or "delete the ability to
use xcb".  I think you mean delete.

2b is your choice 2.


2a is really easy; just drop "or xcb" from the outer if.