Application of package options from within buildlink3.mk?

[Havard Eidnes <he%NetBSD.org@localhost>]

Hi,

I recently had reason to upgrade my pkgsrc on one of my
NetBSD/amd64 hosts running 9.3.

The libxml2 package needed updating, and it's apparently used
~everywhere, so this is a bit of a slog.

During this, I came to build multimedia/ffmpeg7, and configuring
that failed because the setup refused to use gnutls; said it was
"not found", ref.:

=> Checking for portability problems in extracted files
ERROR: gnutls not found using pkg-config

Debugging this with ktrace (that should not really be necessary,
now, should it?) gets me closer to the reason:

  2359      1 pkg-config GIO   fd 2 wrote 53 bytes
       "Package 'p11-kit-1', required by 'gnutls', not found\n"

Now, gnutls's buildlink3.mk has this section:

pkgbase := gnutls
.include "../../mk/pkg-build-options.mk"
# ...
.if ${PKG_BUILD_OPTIONS.gnutls:Mpkcs11}
.include "../../security/p11-kit/buildlink3.mk"
.endif

However, if I in multimedia/ffmpeg7 do

  make show-var VARNAME=PKG_BUILD_OPTIONS.gnutls

it comes up empty, i.e. just outputs a newline.

I had mrg@ do the same in his slightly older pkgsrc, and it came
up with "pkcs11".

I tend to stick to defaults as much as possible, and as far as I
can see I have not messed with anything which should impact this.
I can be wrong, of course...

Before that, I also got a problem with multimedia/libbluray which
said

checking for FT2... no
configure: error: Package requirements (freetype2) were not met:

Package 'libbrotlidec', required by 'freetype2', not found

and again freetype2's buildlink3.mk has

.if ${PKG_BUILD_OPTIONS.freetype2:Mbrotli}
.include "../../archivers/brotli/buildlink3.mk"
.endif

but in multimedia/libbluray if I do

  make show-var VARNAME=PKG_BUILD_OPTIONS.freetype2

it just comes out as "png", so we get the above error.

I'm getting the sense that the application of default options
isn't done properly (anymore?)  The libbluray issue can be worked
around with commenting out the test for the "brotli" pkg option,
then the build proceeds as it should, as can the gnutls by
unconditionally pulling in the p11-kit buildlink3.mk file, but
obviously that's not a committable fix.

Any further clues as to what might be wrong?

This pkgsrc tree was updated to HEAD on June 19 18:20 CEST.

Best regards,

- Håvard