tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Overhauling lang/pear



* On 2025-06-11 at 23:56 BST, Takahiro Kambe wrote:

In message <20250612.000043.879114614090242586.taca%back-street.net@localhost>
	on Thu, 12 Jun 2025 00:00:43 +0900 (JST),
	Takahiro Kambe <taca%NetBSD.org@localhost> wrote:
I've also push a combined fix:

  https://github.com/TritonDataCenter/pkgsrc/commit/9590cd27
Works fine and I found the base php's wrong configuration from it, sigh.

I'll try more tests.
It looks very fine for me.

Is there any reason to drop patch-PEAR_Config.php?

The value of PEAR_CONFIG_DEFAULT_PHP_BIN (defined in PEAR/Config.php)
will change from ${PREFIX}/bin/php${PHP_VER} to ${PREFIX}/bin/php.

I replaced it with a single line in Makefile:

  INSTALL_ENV+=        PHP_PEAR_PHP_BIN=${PHPBIN}

which appears to do the same thing without requiring a patch. The correct php${PHP_VER} appears to be encoded in the resulting pear binary.

If there's something else I'm missing though please let me know.

Thanks,

--
Jonathan Perkin                    pkgsrc.smartos.org
Open Source Complete Cloud   www.tritondatacenter.com


Home | Main Index | Thread Index | Old Index