Re: CMAKE_ARGS <-> CMAKE_CONFIGURE_ARGS

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Sun, May 04, 2025 at 08:36:42AM +0000, nia wrote:
> Was this change discussed anywherre? The commit message just says:
> 
> *: replace CMAKE_ARGS with CMAKE_CONFIGURE_ARGS
> 
> with no justification whatsoever.

I think it was for the split into a consistent set:

# CMAKE_CONFIGURE_ARGS
#       Arguments to pass to CMake during the configure stage.
#
# CMAKE_BUILD_ARGS
#       Arguments to pass to CMake during build. Default: empty
#
# CMAKE_INSTALL_ARGS
#       Arguments to pass to CMake during installation: Default: empty

> For my money, this variable name is both excessively long and
> inconsistent with both Meson (MESON_ARGS) and autotools (CONFIGURE_ARGS).
> 
> If there was going to be a change, I'd rather it be "use CONFIGURE_ARGS
> for every build system". There's no real reason we need three variables.

If we do this, we should also make general BUILD_ARGS and
INSTALL_ARGS.  We already have BUILD_TARGET and INSTALL_TARGET. So we
need to define what the difference is and what belongs where.

Then we need a migration plan, what should be converted to what. And
switch in one go, otherwise we'll just have added variables.

Do you want to come up with details for this?
 Thomas