Re: security/qca2-qt5-ossl and ninja

[Thomas Klausner <wiz%gatalith.at@localhost>]

On Tue, Apr 29, 2025 at 08:00:31PM -0400, Greg Troxel wrote:
> With
> 
>    CMAKE_GENERATOR?=               ninja
> 
> in mk.conf, qca2-qt5-ossl fails to build.  Cleary it just doesn't work
> with ninja.

Yes, the ninja generator doesn't work well with

BUILD_DIRS=     plugins/qca-ossl

The make generator generates a Makefile per sub-directory, but ninja
only has a top-level build.ninja file containing all rules, so we'd
need to find a different target to call instead of trying to build in
a sub-directory.

We have the same problem in print/poppler.

> There's a user-settable variable that I set, and there are no
> package-settable variables to say that make is the only allowed
> GENERATOR.
> 
> 
> I am guessing that:
> 
>   I should set CMAKE_GENERATOR=make.
> 
>   I should amend the docs in cmake/build.mk to say this is the approach
>   for now, because there is no CMAKE_GENERATORS_ACCEPTED
>   package-settable variable.
> 
> 
> If that's wrong, please explain...

Bonus points if you improve cmake/build.mk so we have CMAKE_GENERATORS_ACCEPTED :-)
 Thomas