Re: CVS commit: pkgsrc/security/mit-krb5

[Tobias Nygren <tnn%NetBSD.org@localhost>]

On Tue, 29 Apr 2025 09:41:03 -0400
Greg Troxel <gdt%lexort.com@localhost> wrote:

> The package is buggy in that it does not have USE_CC_FEATURES+= c11, and
> given that one can't know what's default and that upstream doesn't set
> --std, FORCE_C_STANDARD=c11.

> +USE_LANGUAGES=		c
> +USE_CC_FEATURES+=	c11	# not documented, but configure checks
> +FORCE_C_STD=		c11	# build fails in c23 mode

This change should be fine here. In general though I am worried that
venturing too far outside of the domain of "it builds with the default
compiler settings" can cause unneccesary grief down the road.
Especially for packages that provide headers that other
packages in turn may consume. Which is also why I prefer to patch
away language features considered deprecated if it is either a small
patch or the upstream is no longer very active.

-Tobias