Re: _OPSYS_HAS_OSSAUDIO

[Alistair Crooks <alistaircrooks%gmail.com@localhost>]

On Mon, Apr 7, 2025 at 08:11 nia <nia%netbsd.org@localhost> wrote:

Hi all,

This variable is defined in every single mk/platform file, having been
copy and pasted between them. It's defined rather inconsitently, it says
it's for "libossaudio" (which is a NetBSD-ism), however, FreeBSD also
defines it to "yes".

Other operating systems that include some kind of implementation of the
Open Sound System (including Solaris, OpenBSD, UnixWare, DragonFly, and
Linux) define it to "no".

As a result, anything relying on this variable is buggy.

Currently only one package uses this variable. I'd like to change it
to use OSS_TYPE instead and then remove the variable definition from
the mk/platform files.

I fail to see what this would gain you.

If the settings of the definition (the yes/no settings) are wrong, then they should be fixed

If the definition's name is misleading, then it should be fixed

The whole idea of abstracting away from os tests is to make this scalable and workable. Even/especially for corner cases. I can assure you that with the number of platforms that pkgsrc can help, this is the only way to do it, and this proposal concerns me because it fundamentally doesn't understand the issues