Re: [PATCH] Fix rust cargo distfiles with embedded + subversions

[Thomas Klausner <wiz%NetBSD.org@localhost>]

On Sun, Mar 16, 2025 at 03:22:48PM +0000, Taylor R Campbell wrote:
> Currently, for CARGO_CRATE_DEPENDS+= curl-sys-0.4.72+curl-8.6.0,
> lang/rust/cargo.mk will derive the following sites for
> SITES.curl-sys-0.4.72+curl-8.6.0.crate:
> 
> https://static.crates.io/crates/curl-sys/ -https://crates.io/api/v1/crates/curl-sys/8.6.0/download
> 
> The first entry will work, but the second one will fail with 403
> because that's the wrong version for the curl-sys crate -- it's not
> 8.6.0 but 0.4.72+curl-8.6.0.  This should instead be:
> 
> https://static.crates.io/crates/curl-sys/ -https://crates.io/api/v1/crates/curl-sys/0.4.72+curl-8.6.0/download
> 
> The attached patch fixes this for any CARGO_CRATE_DEPENDS entries with
> an embedded + subversion.  The logic is unchanged for entries without
> any embedded + subversion; the new logic is conditional on that.
> 
> This is infrastructure that affects a lot of packages but I think it
> is relatively low risk because (a) there is a working static.crates.io
> entry, and (b) the new logic only affects cases that were broken
> already.  I have been running with this patch since January with no
> adverse consequences that I've seen.  Without this patch, I sometimes
> saw fetch failures.
> 
> OK to commit before branch?

Can you commit this now, please?

Thanks,
 Thomas