tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Combining NOT_FOR_* and BROKEN_ON_*



* On 2025-04-02 at 23:46 BST, David Holland wrote:

On Wed, Apr 02, 2025 at 03:12:51PM +0200, Thomas Klausner wrote:
> We currently have two settings to disable packages for particular
> platforms:
>
> NOT_FOR_* for packages where it "doesn't make sense" for them to be
> built on a platform, and BROKEN_ON_* for packages where it does, but
> they don't build for some reason.
>
> I understand the difference between the two, but I don't see it as a
> useful difference to make - the result is the same, we don't try
> building on that platform.

That is because, to be blunt, Joerg refused to support it in pbulk and
nobody else has gotten around to it.

In an ideal world the distinction would affect the pbulk reporting so
we don't have to wade through "failure" reports about packages that
are NOT_FOR the target. That would then lead to more attention to the
real failures.

Same for PKG_SKIP_REASON and PKG_FAIL_REASON, which are the underlying
logic.

I swear this point came up only a few days ago.

Anyway, I'm quite against any such change. Far better to get around to
making it work properly.

I agree. For me the distinction is clear, and one is perfectly reasonable (this package will never ever be suitable for this platform), and one is in my opinion completely unreasonable (there is some build issue and so I'm going to mark it so that nobody can see what the build issue is any more, thus making it harder for someone to actually fix, or even in some cases leaving it broken indefinitely even though upstream already fixed the problem years ago and it now builds fine).

If you want to remove the latter completely then of course I'm fine with that :) However, merging them so that people start using a reasonable flag for unreasonable reasons, I'm not in favour.

It would also remove the ability for those of us who object to BROKEN* to easily run bulk builds with them neutered so that we continue to get useful build logs.

--
Jonathan Perkin                    pkgsrc.smartos.org
Open Source Complete Cloud   www.tritondatacenter.com


Home | Main Index | Thread Index | Old Index