Re: archivers/py-zstandard broken after update to archivers/zstd-1.5.7

[David Brownlee <abs%absd.org@localhost>]

On Thu, 20 Feb 2025 at 12:17, Thomas Klausner <wiz%gatalith.at@localhost> wrote:
>
> On Thu, Feb 20, 2025 at 11:41:52AM +0000, David Brownlee wrote:
> > This is complicated by the fact that the last py-zstandard release was
> > in 2023, so upstream is at best moribund. It shipped an in-tree zstd.h
> > which needed to be removed to even get 1.5.6 to build
>
> That was 0.22.0. 0.23.0, the current pkgsrc version, was released in
> July 2024, and had zstd 1.5.6 support.  (It's just a "Tag" on github
> and not a "Release", perhaps that misled you.)

Aha - thanks, I should have checked tags as well.

> > So... options include:
> > - fixup the logic which generates zstandard/_cffi.c
> > - copy $PREFIX/include/zstd.h into the build tree, modified to remove
> > the defines
> > - add some "#ifndef DISABLE_157_COMPAT_RENAMES" to the installed zstd.h
> > - revert zstd to 1.5.6
>
> I chose two options you didn't list here:
> - report this upstream
> - use the included zstd 1.5.6 for now

That seems an eminently more sensible option - thanks

David