* On 2025-01-12 at 14:52 GMT, Taylor R Campbell wrote:
I think what we should do -- for this case and many other cases -- is
have www/firefox include a file like this instead of buildlink3.mk:
# lang/clang/tool.mk
.if !defined(CLANG_TOOL_MK)
CLANG_TOOL_MK= # defined
TOOL_DEPENDS+= clang>=18.0.0:../../lang/clang
TOOLS_CREATE+= clang
TOOLS_PATH.clang= ${TOOLBASE}/bin/clang
.endif
Yup, using buildlink3 for tool depends is very wrong, especially as you either end up with a runtime dependency on the package which is completely unnecessary, or you run the risk of DEPMETHOD=build messing up indirect dependencies. There are also cases where the wrong includes will be used, unless you add ugly hacks in post-wrapper to remove them manually.
Go for it. -- Jonathan Perkin pkgsrc.smartos.org Open Source Complete Cloud www.tritondatacenter.com