Re: 2024Q4 gif2png build fails

[Taylor R Campbell <riastradh%NetBSD.org@localhost>]

> Date: Thu, 26 Dec 2024 16:10:56 +0000 (UTC)
> From: Benny Siegert <bsiegert%gmail.com@localhost>
> 
> On Thu, 26 Dec 2024, Taylor R Campbell wrote:
> 
> >> New with go123, you need to mount procfs :-(
> >
> > What does it need procfs for?  Maybe we can work around that?
> 
> Yes, this is a regression in go123, there is also an open PR for it 
> (pkg/58830). It will be fixed with go124, which is currently at RC1 in 
> wip.

Thanks!

> > Or, if not, maybe we can add a check to make the failure more obvious
> > like:
> >
> > .if ${OPSYS} == "NetBSD" && make(build) && !exists(/proc/version)
> > PKG_FAIL_REASON+=	"${PKGPATH} requires /proc to be mounted."
> > .endif
> 
> This would be an option. Alternatively, I could backport the fix.

Patch looks pretty straightforward.  Would have been nice to backport
it before the branch, but since the sysctl and /proc vectors both
reach the same data, I think this is reasonably low-risk to backport
even to the 2024Q4 branch.

   1820 		bp = pown->p_path;

https://nxr.netbsd.org/xref/src/sys/miscfs/procfs/procfs_vnops.c?r=1.233#1820

   2987 		error = sysctl_copyout(l, p->p_path, oldp, copylen);

https://nxr.netbsd.org/xref/src/sys/kern/kern_proc.c?r=1.276#2987