Re: ocaml, dune, environment, PKG_CONFIG in the environment

[Greg Troxel <gdt%lexort.com@localhost>]

David Holland <dholland-pkgtech%netbsd.org@localhost> writes:

> On Sun, Nov 24, 2024 at 09:42:04AM -0500, Greg Troxel wrote:
>  > I just committed a kludge to ocaml-lablgtk3 that lets it build.
>  > Essentially, dune seems to choke if PKG_CONFIG is defined in the
>  > environment.  That's probably a dune bug to be fixed, but for now
>  > avoiding that seems to build a working package.
>
> I can't replicate the problem. What are the symptoms? What is
> PKG_CONFIG being passed as? If you unset it, dune uses "pkg-config",
> which is fine for pkgsrc. But it seems like for it to be failing we
> must be passing something wrong, and we shouldn't do that.

You mean that if you back out my hack, and build the package, it builds?

The symptoms are an error message about not being able to run
pkg-config, and thus not finding stuff.

It seems that the wrapper script being a script is not it, but
PKG_CONFIG was /path/to/wrapper/script-or-copied-binary, and unsetting
that made it work.


>  > 1) Looking at lang/ocaml/ocaml.mk, I notice that the build envrironment is
>  > not set in one of the do-build overrides, and that seems like a bug.  So
>  > I am inclined to commit the following as an "obvious bugfix".  Comments?
>
> That was obviously wrong, yeah.

ok, will do

>  > and I am more or less inclined to just put that into ocaml.mk, on the
>  > theory that this is a dune bug, not a lablgtk3 bug.
>
> Please don't until we understand what's going on...

Yeah, I am more inclined to say I might than actually to do it!