Hey Jonathan, (tech-pkg@) > On 26 Nov 2024, at 02:46, Jonathan Perkin <jperkin%mnx.io@localhost> wrote: > > * On 2024-11-25 at 23:57 GMT, Pierre Pronchery wrote: > >> When trying to build lang/python312 from pkgsrc (2024Q3 branch), it >> fails with the following errors: >> >> [...] >> >> Re-introducing the following line in the Makefile allows the build to >> complete: (eg lang/python310 has it) >> >>> +.include "../../devel/gettext-lib/buildlink3.mk” >> >> There are still issues with the PLIST (WRT expat) but it looks like a >> separate problem. >> >> Can I commit this change? > > I don't see this failure in my bulk builds, so I would prefer that some additional work is done to identify why this is required. Also you say this in 2024Q3, so I'd like to see any changes verified on trunk first before committing there. > > This whole gettext-lib change has been an absolute pain. With an unmodified pkgsrc-current from just now, lang/python312 (python312-3.12.7nb3) also fails on my local macOS with: > Undefined symbols for architecture x86_64: > "_libintl_bindtextdomain", referenced from: > __locale_bindtextdomain in _localemodule.o > "_libintl_dcgettext", referenced from: > __locale_dcgettext in _localemodule.o > "_libintl_dgettext", referenced from: > __locale_dgettext in _localemodule.o > "_libintl_gettext", referenced from: > __locale_gettext in _localemodule.o > "_libintl_setlocale", referenced from: > __locale_setlocale in _localemodule.o > __locale_setlocale in _localemodule.o > __locale_localeconv in _localemodule.o > __locale_localeconv in _localemodule.o > __locale_localeconv in _localemodule.o > __locale_localeconv in _localemodule.o > "_libintl_textdomain", referenced from: > __locale_textdomain in _localemodule.o > ld: symbol(s) not found for architecture x86_64 > clang: error: linker command failed with exit code 1 (use -v to see invocation) > gmake: *** [Makefile:1315: Programs/_freeze_module] Error 1 > gmake: *** Waiting for unfinished jobs.... > *** Error code 2 > > Stop. > bmake[1]: stopped making "install" in pkgsrc-current/lang/python312 > *** Error code 1 > > Stop. > bmake: stopped making "install clean" in pkgsrc-current/lang/python312 I’m running the latest Sonoma 14.7.1: > Darwin hostname 23.6.0 Darwin Kernel Version 23.6.0: Thu Sep 12 23:34:49 PDT 2024; root:xnu-10063.141.1.701.1~1/RELEASE_X86_64 x86_64 After adding: > .include "../../devel/gettext-lib/buildlink3.mk" As mentioned before, Modules/pyexpat.so <http://pyexpat.so/> still fails to build. By removing this line: > CONFIGURE_ARGS+= --with-system-expat lang/python312 builds again. Cheers, -- khorben
Attachment:
signature.asc
Description: Message signed with OpenPGP