tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Automated pkgsrc commit testing



On 07/23, Jonathan Perkin wrote:
> In another attempt to improve the quality of what is committed to pkgsrc,
> I've spent the last few days implementing an automated testing rig on
> GitHub.

Nice!

> Here is what I've implemented so far.
> 
>  * The commit message is checked to conform to our current standards,
>    i.e. "pkg: description" in the first line, limited to 50 characters,
>    followed by a blank line, followed by further details with lines
>    limited to 80 characters.

The pkgsrc Guide says the first line must be limited to 65 characters,
not 50:

  https://www.netbsd.org/docs/pkgsrc/submit.html#commit-messages

So, one or the other should be changed to be consistent.

> If you would like to get involved, have access to the GitHub org, have any
> questions, or have suggestions on any other tests you'd like me to implement
> (or implement yourself), please let me know.

I'd like to be added (if allowed; I'm not a pkgsrc developer): jlmuir.

Also, how do you envision this working after someone submits a PR?  I
assume no PRs are actually merged, so after the workflow runs, are you
thinking that people should just close the PR?

Lewis


Home | Main Index | Thread Index | Old Index