Re: Proposed update to bmake-20240711

[Roland Illig <roland.illig%gmx.de@localhost>]

Am 13.07.2024 um 07:24 schrieb Simon Gerraty:
> On Sat, 13 Jul 2024 06:09:13 +0200, Roland Illig writes:
>>> The test suite isn't 100% clean on macOS, but I think that this is
>>> mostly due to output differences when using mksh:
>>>
>>>    https://gist.github.com/jperkin/a46993a5ee6b680fc7308087daf13f80
>>
>> The "Abort trap" and "exit status 134" cases look strange to me. Do you
>
> 134 is from the SIGABRT
>
>> have a ktrace/strace or gdb backtrace available for that case? To run
>> that test in isolation:
>
> I don't have mksh on Darwin, on FreBSD with mksh as .SHELL shell-csh seg
> faults due to:
>
> frame #5: 0x000000000021a57c bmake`Job_ParseShell(line="name=\"csh\"
> path=\"/bin/csh\"") at job.c:2500:3
>    2497                         }
>    2498                 }
>    2499         } else {
> -> 2500                 free(shellPath);

Thanks for the fix, it looks good. When I changed shellPath to a
malloced string a few days ago, I couldn't see DEFSHELL_PATH as that
doesn't occur in the NetBSD variant, only in the bmake distribution.

Roland