Re: WRKSRC when using github

[David Holland <dholland-pkgtech%netbsd.org@localhost>]

On Sun, May 19, 2024 at 10:04:11AM -0500, Jason Bacon wrote:
 > I'm curious if there is a reason for this distinction in bsd.pkg.mk:
 > 
 > .if defined(GITHUB_TAG)
 > WRKSRC?=                ${WRKDIR}/${GITHUB_PROJECT}-${GITHUB_TAG:C/^v//}
 > .else
 > WRKSRC?=                ${WRKDIR}/${DISTNAME:U${PKGNAME_NOREV}}
 > .endif

At one point the reason was that it ineracted with the fetch behavior
and the naming generated upstream by github to make the default WRKSRC
be useful in both cases.

If things have changed, it should be updated accordingly.

 > As far as I can tell, ${GITHUB_PROJECT}-${GITHUB_TAG:C/^v//} produces
 > the correct WRKSRC whenever GITHUB_PROJECT is defined.  I.e., GITHUB_TAG
 > defaults to the package version.

GITHUB_TAG is in general whatever the tag on the upstream git repo is,
which can be stuff like "release-5.001.003" or "interim-6-oct15", and
I believe that's also what comes through in the download tarball.

-- 
David A. Holland
dholland%netbsd.org@localhost