Re: print-PLIST and options

[Thomas Klausner <wiz%gatalith.at@localhost>]

On Mon, May 06, 2024 at 06:50:35PM +0400, Aleksey Cheusov wrote:
> Hi every one.  Some developers asked me to add PRINT_PLIST_AWK for
> packages where I added option "nls".  Idea is to simplify future updates
> of such packages without "nls" breakages.
> 
> Personally, I think this approach is impractical for option "nls". In my
> view it would be better to improve plist-PLIST output unconditionally,
> not on per-package basis. Patch is below.
> 
> With this approach:
> 1) future package updates won't break this option
> 2) packages will semi-automatically obtain "nls" option,
>    especially new one.

I think it's too early for that and will break too much if committed
as-is, since the package will need to have "PLIST_VARS+=nls" and
configure logic that disables nls to make this work, and the nls
option is not (yet?) well-supported in pkgsrc.

The 'man' part will cause even more breakage since ~no configure
system has code to disable installation of _some_ man pages, so manual
${RM} in the post-install will need to be added - which is manual work
anyway.

I'd prefer if it you made the share/locale logic conditional on the
existence of an 'nls' option, or put it in the affected packages, and
removed the 'man' part and just added that fragment to the packages
where it's needed.

> Index: mk/plist/print-plist.mk
> ===================================================================
> RCS file: /cvsroot/pkgsrc/mk/plist/print-plist.mk,v
> retrieving revision 1.36
> diff -u -r1.36 print-plist.mk
> --- mk/plist/print-plist.mk	10 Jun 2020 16:06:09 -0000	1.36
> +++ mk/plist/print-plist.mk	6 May 2024 14:32:16 -0000
> @@ -7,11 +7,18 @@
>  #  - substitute for platform or package specifics substrings
>  #
>  # Usage:
> -#  - make install
> +#  - make build
> +#  - make do-install

Why this change?

Cheers,
 Thomas