Re: no downloads except during fetch phase

[Thomas Klausner <wiz%netbsd.org@localhost>]

On Tue, Apr 30, 2024 at 12:16:58AM +0200, Joerg Sonnenberger wrote:
> On Tuesday, April 30, 2024 12:02:15 AM GMT+2 Thomas Klausner wrote:
> > On Mon, Apr 29, 2024 at 04:32:25PM +0200, Joerg Sonnenberger wrote:
> > > On Monday, April 29, 2024 4:26:36 PM GMT+2 Thomas Klausner wrote:
> > > > On Mon, Apr 29, 2024 at 04:19:15PM +0200, Joerg Sonnenberger wrote:
> > > > > On Monday, April 29, 2024 1:17:36 PM GMT+2 Thomas Klausner wrote:
> > > > > > Hi!
> > > > > > 
> > > > > > Since this keeps popping up, I thought how we could disable downloads
> > > > > > during configure/build/test, and came up with the attached patch.
> > > > > > 
> > > > > > Basically, it's setting the proxy environment variables to an invalid
> > > > > > value, so everything that honors them will break with a hopefully easy
> > > > > > to understand error.
> > > > > 
> > > > > Two comments.
> > > > > 
> > > > > 1) Isn't it enough to add it to ALL_ENV? The rest should inherit from that.
> > > > 
> > > > That would be enough, but then the fetch stage is also affected, which
> > > > we don't want.
> > > 
> > > But mk/fetch/fetch is not invoked with ALL_ENV?
> > 
> > You're right. This is even easier than I though :)
> 
> Right, just please provide a flag to disable this for a package. It's useful
> for developers (for getting the files initially before sticking them
> into distdir/ as well as for custom packages.

I've just committed this. You can set ALLOW_NETWORK_ACCESS in your
environment if you want to have an environment without the proxy
variables set.

Thanks for the suggestions,
 Thomas