Re: Fix mk/fetch/github.mk

[Greg Troxel <gdt%lexort.com@localhost>]

Now that we're back to a state without significant breakge, we can
discuss what we ought to do without so much time pressure.

Overall, my impressions are (and they are a little fuzzy):

  GITHUB_TAG should only be used for things that are actual git tags

  GITHUB_HASH (bikeshed, making that up) should be used for things that
  are (currently SHA-1) commit hashes

  I am unclear on if there is anything else.


I grepped for GITHUB_TAG in */Makefile* (or something close to that),
including wip and TDC.  I got 2236 lines.  uniq -c and sort -nr leads
to:

  1187 v${PKGVERSION_NOREV}
   159 ${PKGVERSION_NOREV}
    57 ${DISTNAME}
    34 v${VERSION}
    20 refs/tags/v${PKGVERSION_NOREV}
    13 release-${PKGVERSION_NOREV}
     8 V${PKGVERSION_NOREV}
     7 v${PORTVERSION}
     5 v${PV}
     5 v${PKGVERSION}
     5 r${PKGVERSION_NOREV}
     5 ${VERSION}
     4 refs/tags/${DISTNAME}
     4 4.13.0
     4 ${PKGNAME_NOREV}
     3 v1.2.0
     3 v.${PKGVERSION_NOREV}
     3 v${DISTVERSION}
     3 ${PV}
     3 ${PKGVERSION}
     2 version-${PKGVERSION_NOREV}
     2 v0.35.0
     2 v0.2.5
     2 v0.2
     2 v${PKGVERSION_NOREV}-0
     2 v${PKGVERSION:S/./_/g}
     2 release_${PKGVERSION_NOREV}
     2 release-v${PKGVERSION_NOREV}
     2 release-${VERSION}
     2 rel-${PKGVERSION_NOREV}

which does make we wonder how the 1187 worked.  Most of the above is
basically variant tag names.  Then

   2 refs/tags/master.mint21
   2 fb89af3b2e976c2ccb42d861324aa40591f5cadb
   2 ea0ca83ba24dce80c20ca589b838a281fe5deb0c
   2 e0c8050286b01c8b6b70a6c773457753e5a7a567
   2 c471264f8df1fd73621973737d74f4f48e8eb9d1
   2 Version-${PKGVERSION_NOREV}
   2 OTP-${PKGVERSION_NOREV}
   2 Audacity-${PKGVERSION_NOREV}
   2 984f1493e8612cd59a269569bf8c06e25e4e604c
   2 88eea875b3b82a0e50cbb112e0aea2259dc2e011
   2 79ac5973407703780bd82e07be9289778a75c83b
   2 510270ecf2e342a81d5dffbf38505bfe18d23dca
   2 4.13.1
   2 338a259d9fb411f7217f5e3348c2c1bbef834f47
   2 329cfcfc0448a45a0779ded7b51332a343d02a18
   2 2cc4a97bb3b08e1c336578b36af5970ce98c931a
   2 20240101
   2 1389dcec6e3242948682eb3e3ce8ead8be2772d8
   2 0f2fd0a5051e058b82efd310679265bcda0b5b03
   2 0480a776c8a0b9c05cba4037084f74c5f8c042f6
   2 0375b83239ea352a708112ad1dc87606c174f11f
   2 0.3.1
   2 0.1
   2 ${PORTVERSION}
   2 ${DISTNAME:S/^luv-//1}
   1 win32-${OTDATEVER}${OTVERSUFX}
   1 wakeonlan-${PKGVERSION_NOREV}
   1 v{PKGVERSION_NOREV}
   1 version_${VERSION}
   1 version_${PKGVERSION_NOREV}
   1 version_${PKGVERSION:S/./v/g}
   1 version_${PKGVERSION:C/(beta|rc)/-\1/}
   1 ver_${PKGVERSION_NOREV}
   1 ver.${VERSION}
   1 ver-${PKGVERSION_NOREV}
   1 v_${PKGVERSION_NOREV:S/./_/g}


which is a mix of commits and tags, a fair bit of

   1 refs/tags/v4.09.1
   1 refs/tags/v2.0.0rc2
   1 refs/tags/v1.2.5
   1 refs/tags/v0.6.0
   1 refs/tags/v0.3
   1 refs/tags/v0.0.1_update20200803

and a bunch more hashes.


So it seems we have some single words, and some refs/tags.


Is there more than a sha-1 and a tag form?