Re: CVS commit: pkgsrc/devel/libffi

["David H. Gutteridge" <david%gutteridge.ca@localhost>]

On Sat, 3 Feb 2024 at 16:44:21 +0100, Thomas Klausner wrote:
> On Sat, Feb 03, 2024 at 12:17:16PM +0000, Makoto Fujiwara wrote:
> > Module Name:	pkgsrc
> > Committed By:	mef
> > Date:		Sat Feb  3 12:17:16 UTC 2024
> >
> > Modified Files:
> > 	pkgsrc/devel/libffi: buildlink3.mk
> >
> > Log Message:
> > (devel/libffi) python311-3.11.7 wants 3.4.4
>
> If python wants it, you should add
>
> BUILDLINK_API_DEPENDS.libffi+=       libffi>=3.4.4
>
> to python's Makefile, not change ABI depends here.
> Thomas
>
> > To generate a diff of this commit:
> > cvs rdiff -u -r1.12 -r1.13 pkgsrc/devel/libffi/buildlink3.mk
> >
> > Please note that diffs are not public domain; they are subject to the
> > copyright notices on the relevant files.
>
> > Modified files:
> >
> > Index: pkgsrc/devel/libffi/buildlink3.mk
> > diff -u pkgsrc/devel/libffi/buildlink3.mk:1.12 
> > pkgsrc/devel/libffi/buildlink3.mk:1.13
> > --- pkgsrc/devel/libffi/buildlink3.mk:1.12	Tue Jun 28 11:31:46 2022
> > +++ pkgsrc/devel/libffi/buildlink3.mk	Sat Feb  3 12:17:16 2024
> > @@ -1,4 +1,4 @@
> > -# $NetBSD: buildlink3.mk,v 1.12 2022/06/28 11:31:46 wiz Exp $
> > +# $NetBSD: buildlink3.mk,v 1.13 2024/02/03 12:17:16 mef Exp $
> >
> >  BUILDLINK_TREE+=	libffi
> >
> > @@ -6,7 +6,7 @@ BUILDLINK_TREE+=	libffi
> >  LIBFFI_BUILDLINK3_MK:=
> >
> >  BUILDLINK_API_DEPENDS.libffi+=	libffi>=1.20
> > -BUILDLINK_ABI_DEPENDS.libffi+=	libffi>=3.4.2nb3
> > +BUILDLINK_ABI_DEPENDS.libffi+=	libffi>=3.4.4
> >  BUILDLINK_PKGSRCDIR.libffi?=	../../devel/libffi
> >  .endif # LIBFFI_BUILDLINK3_MK

What is the situation where Python 3.11 needs libffi 3.4.4 minimum to
build? I was not able to reproduce this. I successfully built Python
3.11.7 with libffi 3.4.2nb2 on NetBSD 10.99.10. I don't see anything in
the Python source that suggests 3.4.4 is the minimum for libffi, other
than references to Windows-specific considerations?

If it really does need 3.4.4 minimum in some situations, then presumably
this is also relevant (or will be shortly) for Python 3.12.

Either we need to correctly bump the API minimums in Python packages,
or we don't. Right now just the ABI was wrongly bumped. I imagine we're
not going to change that back now, given over a week has gone by.

Dave