Re: sysutils/xentools418 CHECK_RELRO_SKIP

[Brook Milligan <brook%nmsu.edu@localhost>]

> On Jan 8, 2024, at 4:29 PM, Roland Illig <roland.illig%gmx.de@localhost> wrote:
> 
> 09.01.2024 00:15:09 Brook Milligan <brook%nmsu.edu@localhost>:
>> +CHECK_RELRO_SKIP+= lib/debug/@PREFIX@/libexec/xen/boot/xen-shim-syms
> 
> Doesn't the direct ${PREFIX} work here as well? The code looks as if CHECK_RELRO_SKIP is evaluated late enough.

I tried one version of that and it did not work.  I’ve circled back, though, and realized that the version in the patch below does in fact work.  I cannot think of anything better and will commit this soonish unless someone has better ideas.

Cheers,
Brook


--- sysutils/xentools418/Makefile.orig	2023-11-21 04:37:03.000000000 -0700
+++ sysutils/xentools418/Makefile	2024-01-08 19:42:07.656542724 -0700
@@ -40,7 +40,7 @@
 			tools/qemu-xen/scripts/qemu-binfmt-conf.sh
 CHECK_RELRO_SKIP=	libexec/xen/boot/hvmloader
 CHECK_RELRO_SKIP+=	libexec/xen/boot/xen-shim
-CHECK_RELRO_SKIP+=	lib/debug/usr/pkg/libexec/xen/boot/xen-shim-syms
+CHECK_RELRO_SKIP+=	lib/debug${PREFIX}/libexec/xen/boot/xen-shim-syms
 
 EGDIR=			${PREFIX}/share/examples/xen
 MESSAGE_SUBST+=		EGDIR=${EGDIR}