Re: CVS commit: pkgsrc/graphics/tiff

[Joerg Sonnenberger <joerg%bec.de@localhost>]

On Sunday, December 17, 2023 6:24:23 PM CET Thomas Klausner wrote:
> On Sun, Dec 17, 2023 at 05:01:59PM +0000, Dr. Thomas Orgis wrote:
> > Module Name:	pkgsrc
> > Committed By:	thor
> > Date:		Sun Dec 17 17:01:59 UTC 2023
> > 
> > Modified Files:
> > 	pkgsrc/graphics/tiff: Makefile buildlink3.mk
> > 
> > Log Message:
> > graphics/tiff: explicitly use libdeflate
> > 
> > Otherwise it is found and used in a host GNU/Linux distro, messing up dependents
> > which lack it in buildlinks.
> ...
> > Index: pkgsrc/graphics/tiff/buildlink3.mk
> > diff -u pkgsrc/graphics/tiff/buildlink3.mk:1.26 pkgsrc/graphics/tiff/buildlink3.mk:1.27
> > --- pkgsrc/graphics/tiff/buildlink3.mk:1.26	Sat Oct 21 17:10:42 2023
> > +++ pkgsrc/graphics/tiff/buildlink3.mk	Sun Dec 17 17:01:59 2023
> > @@ -1,4 +1,4 @@
> > -# $NetBSD: buildlink3.mk,v 1.26 2023/10/21 17:10:42 gdt Exp $
> > +# $NetBSD: buildlink3.mk,v 1.27 2023/12/17 17:01:59 thor Exp $
> >  
> >  BUILDLINK_TREE+=	tiff
> >  
> > @@ -10,6 +10,7 @@ BUILDLINK_ABI_DEPENDS.tiff+=	tiff>=4.6.0
> >  BUILDLINK_PKGSRCDIR.tiff?=	../../graphics/tiff
> >  
> >  .include "../../devel/zlib/buildlink3.mk"
> > +.include "../../devel/libdeflate/buildlink3.mk"
> >  .include "../../archivers/xz/buildlink3.mk"
> >  .include "../../graphics/jbigkit/buildlink3.mk"
> >  .include "../../mk/jpeg.buildlink3.mk"
> > 
> 
> 
> When you add a dependency to the buildlink3.mk file, you need to
> "revbump.py graphics/tiff".
> 
> I think it's quite close to the branch start for such a big revbump,
> so perhaps you could instead disable the libdeflate detection?

It also doesn't make sense to have use zlib and libdeflate. I'm strongly
in favor of just disabling libdeflate detection.

Joerg