tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Avoiding :M[Yy][Ee][Ss] constructs

Am 16.11.2022 um 13:35 schrieb Jonathan Perkin:
* On 2022-11-16 at 11:56 GMT, Thomas Klausner wrote:

Log Message:
libXft: pkglint cleanup


-.if !empty(CHECK_BUILTIN.libXft:M[nN][oO])
+.if ${CHECK_BUILTIN.libXft:M[nN][oO]}

Could we get consensus and pkglint support for changing the suggestion
for this type of construct to be:

   .if ${CHECK_BUILTIN.libXft:U:tl} == no

instead?  I find it significantly reduces noise and is a lot more
readable.  Bonus points for identifying situations where the :U can be
safely dropped.

Fully agree, as the ':tu' and ':tl' modifiers have been available since
2002 in NetBSD make and since at least 2005 in pkgsrc.

I will update the pkgsrc guide and then implement this cleanup in
pkglint. The ingredients for that cleanup are already there, so it
shouldn't take too long.


Home | Main Index | Thread Index | Old Index