tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: Avoiding :M[Yy][Ee][Ss] constructs



Jonathan Perkin <jperkin%mnx.io@localhost> writes:

> * On 2022-11-16 at 11:56 GMT, Thomas Klausner wrote:
>
>>Log Message:
>>libXft: pkglint cleanup
>>
>> [...]
>>
>>-.if !empty(CHECK_BUILTIN.libXft:M[nN][oO])
>>+.if ${CHECK_BUILTIN.libXft:M[nN][oO]}
>
> Could we get consensus and pkglint support for changing the suggestion
> for this type of construct to be:
>
>   .if ${CHECK_BUILTIN.libXft:U:tl} == no
>
> instead?  I find it significantly reduces noise and is a lot more
> readable.  Bonus points for identifying situations where the :U can be
> safely dropped.

[pmc hat off]
OK, with me, but the guide needs updating and then pkglint can warn
about things that don't follow the rules in the guide.

Attachment: signature.asc
Description: PGP signature



Home | Main Index | Thread Index | Old Index