parallel/pvm3 on NetBSD-current

[Havard Eidnes <he%NetBSD.org@localhost>]

Hi,

my bulk build has hit parallel/pvm3 which doesn't want to build &
install (without help, that is).  The original error is

=> Generating post-install file lists
pkg_create: can't stat `/usr/pkgsrc/parallel/pvm3/work/.destdir/usr/pkg/pvm3/bin/NETBSDPOWERPC/fgexample'

but it turns out earlier errors were masked by "ignore make
errors", and a typical error was

libtool-fortran: link: gfortran -Wl,-rpath -Wl,/usr/pkg/pvm3/lib/NETBSDPOWERPC -O -o .libs/fgexample ../../examples/gexample.f  -L../../lib/NETBSDPOWERPC -L../../lib/NETBSDPOWERPC/.libs -lfpvm3 -lgpvm3 -lpvm3 -Wl,-rpath,/usr/pkg/pvm3/lib/NETBSDPOWERPC
../../examples/gexample.f:153:33:

  149 |       call pvmfreduce( PvmSum, colsum, dimension, INTEGER4, SUMTAG,
      |                               2  
......
  153 |       call pvmfreduce( calcprod, colprod, dimension, REAL8, PRODTAG,
      |                                 1
Error: Type mismatch between actual argument at (1) and actual argument at (2) (REAL(8)/INTEGER(4)).
make[2]: *** [/usr/pkgsrc/parallel/pvm3/work/pvm3/examples/Makefile.aimk:218: fgexample] Error 1
make[2]: Leaving directory '/usr/pkgsrc/parallel/pvm3/work/pvm3/examples/NETBSDPOWERPC'
make[1]: [Makefile.aimk:111: e] Error 2 (ignored)

and it tries to pass both an INTEGER and an REAL*8 array as the
second arg, and modern gcc 10 based gfortran doesn't like that.

Googling leads to "build with -fallow-argument-mismatch" being
the previaling wisdom, ref.

https://github.com/Unidata/netcdf-fortran/issues/212

Next up is

=> Checking for RELRO in pvm-3.4.6nb2
ERROR: pvm3/bin/NETBSDPOWERPC/fgexample: missing RELRO

etc., and grep'ing leads to CHECK_RELRO=no being a workaround for
that.

So with that I end up with this diff:

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/parallel/pvm3/Makefile,v
retrieving revision 1.65
diff -u -p -r1.65 Makefile
--- Makefile    20 Mar 2019 10:55:21 -0000      1.65
+++ Makefile    26 Jun 2022 16:04:12 -0000
@@ -37,6 +37,9 @@ MAKE_ENV+=            PVMLIB_VER=3:4
 MAKE_ENV+=             PVM_DIR=${PVM_DIR:Q}
 BUILD_TARGET=          all install
 
+FFLAGS+=               -fallow-argument-mismatch
+CHECK_RELRO=           no
+
 REPLACE_CSH=           ${WRKSRC}/lib/debugger ${WRKSRC}/lib/debugger2
 
 # Set PVM_ARCH to the correct value for this machine platform.

I suspect these issues are not MD, but would like second opinions.

I have not tested the result, but contrary to before the package
now installs on my macppc.

Regards,

- Håvard