Re: PR 35340 (empty ancestors of OWN_DIRS get removed by pkg_delete)

[David Holland <dholland-pkgtech%netbsd.org@localhost>]

On Sun, May 15, 2022 at 01:46:19AM +0200, Joerg Sonnenberger wrote:
 > > There is a problem with the OWN_DIRS support, which is that it creates
 > > directories with mkdir -p and then removes them again afterwards with
 > > rmdir -p. This causes any now-empty ancestors of the directories in
 > > OWN_DIRS to disappear, regardless of whether pkgsrc created them,
 > > which isn't right and is occasionally problematic (in the original
 > > report, it lead to /var/tmp disappearing).
 > 
 > So does pkg_delete for other directories. I'm inclined to just ignore
 > this as "Don't do this" as any fix is likely going to end up hard-coding
 > a lot more to-be-preserved prefixes than it fixes real problems.

IDK. It doesn't come up that often (and we can probably avoid ever
creating anything in /var/tmp again) but it seems likely that other
cases will arise. In fact, I'm vaguely recalling other instances...

Anyway, the proposed fix isn't to hard-code any to-be-preserved
prefix, it's to explicitly install ancestor directories, so I think
your objection is spurious.

-- 
David A. Holland
dholland%netbsd.org@localhost