[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: [PATCH] mk/git-package.mk: Improve check if update of Git archive is necessary
Am 13.03.2022 um 17:51 schrieb Mateusz Poszwa:
I noticed that preparations to update Git-based packages in pkgsrc-wip
took increasingly long time. It occurred to me that I haven’t seen the
‘Creating cached Git archive’ step being performed for a very long time.
I took a look at pkgsrc/distfiles/git-packages and saw that most of
the archives there were stuck at 12th of April 2018, and the others
had even earlier modification dates. The date coïncides with e5fc07c8.
I analysed the change and I think I found and fixed the problem,
but I’m not confident enough to push my correction to a module
used by so many packages. Can I have it reviewed/tested please?
Your patch looks good to me. I'm preparing additional tests for
mk/tests, to ensure that this particular feature will work as intended
and not break again in the future. Feel free to commit your change
right now, I will take care of adding the tests.
If you want, you can have a try at the tests yourself, but I admit that
it's a bit difficult to understand all the test setup and their details.
Main Index |
Thread Index |