Re: Warning about BLAS choice and math/arpack-ng (needed for math/octave).

["Dr. Thomas Orgis" <thomas.orgis%uni-hamburg.de@localhost>]

Am Wed, 23 Jun 2021 20:02:14 +0200
schrieb "Dr. Thomas Orgis" <thomas.orgis%uni-hamburg.de@localhost>: 

> Am Wed, 23 Jun 2021 13:55:31 -0400
> schrieb Greg Troxel <gdt%lexort.com@localhost>: 
> 
> > As long as the build with no modifications works, that's the most
> > important thing.  
> 
> Yes. If you run with the default BLAS_TYPE=netlib, the FindCMake finds
> libblas.so and is happy. It could also find libopenblas.so if you
> installed that. This might be unexpected. You might want to pull up the
> patch I am preparing right now to avoid this uncertainty.

I screwed up the commit message (empty by accident), but the hotfix to
avoid unpredicted builds is in revision 1.6 of math/arpack-ng/Makefile now:

Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/math/arpack-ng/Makefile,v
retrieving revision 1.5
diff -u -r1.5 Makefile
--- Makefile	11 May 2021 10:18:37 -0000	1.5
+++ Makefile	23 Jun 2021 18:09:54 -0000
@@ -1,6 +1,7 @@
 # $NetBSD: Makefile,v 1.5 2021/05/11 10:18:37 prlw1 Exp $
 
 DISTNAME=	arpack-ng-3.8.0
+PKGREVISION=	1
 CATEGORIES=	math
 MASTER_SITES=	${MASTER_SITE_GITHUB:=opencollab/}
 
@@ -19,6 +20,14 @@
 CMAKE_ARG_PATH=	..
 CMAKE_ARGS+=	-DBUILD_SHARED_LIBS:BOOL=ON
 
+BLAS_ACCEPTED=	netlib openblas
+.include "../../mk/blas.buildlink3.mk"
+.if ${BLAS_TYPE} == "netlib"
+CMAKE_ARGS+=	-DBLA_VENDOR=Generic
+.elif ${BLAS_TYPE} == "openblas"
+CMAKE_ARGS+=	-DBLA_VENDOR=OpenBLAS
+.endif
+
 TEST_TARGET=	test
 
 pre-configure:
@@ -26,5 +35,4 @@
 
 INSTALLATION_DIRS=	lib
 
-.include "../../mk/blas.buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"


This gives a clear error before attempting to build with the wrong BLAS.


Alrighty then,

Thomas

-- 
Dr. Thomas Orgis
HPC @ Universität Hamburg