Re: x11/qt5-qtbase dependency on libdrm on Linux?

["Dr. Thomas Orgis" <thomas.orgis%uni-hamburg.de@localhost>]

Am Mon, 24 May 2021 22:22:41 +0000
schrieb nia <nia%NetBSD.org@localhost>: 

> On Mon, May 24, 2021 at 08:33:38PM +0200, Dr. Thomas Orgis wrote:
> > There's this other block already for GL/MesaLib stuff. It's inside
> > !Darwin already. Does this patch make more sense?  
> 
> yes, this is better, although:
> 
> - the style of the conditional should be consistent with the
>   other one

I.e. it shouldn't trigger a syntax error … a typo with the
parenthesis.

> - MESALIB_SUPPORTS_DRI will already be no on Darwin, so we
>   don't need to wory about that. Including features.mk
>   actually has no side effects and does not force a dependency
>   on Mesa (currently) so it doesn't need to be conditionalized

Hm. The whole block is

.if ${OPSYS} != "Darwin"
.include "../../fonts/fontconfig/buildlink3.mk"
.include "../../graphics/glu/buildlink3.mk"
.  if !empty(MESALIB_SUPPORTS_EGL:Myes)
PLIST.egl=      yes
.  endif
.  if !empty(MESALIB_SUPPORTS_DRI:Myes)
CONFIGURE_ARGS+=       -kms
.include "../../x11/libdrm/buildlink3.mk"
.  endif
BUILDLINK_API_DEPENDS.libxcb+=  libxcb>=1.11
.include "../../x11/libxcb/buildlink3.mk"
.include "../../x11/xcb-util/buildlink3.mk"
.include "../../x11/xcb-util-image/buildlink3.mk"
.include "../../x11/xcb-util-keysyms/buildlink3.mk"
.include "../../x11/xcb-util-renderutil/buildlink3.mk"
.include "../../x11/xcb-util-wm/buildlink3.mk"
.include "../../x11/libSM/buildlink3.mk"
.include "../../x11/libX11/buildlink3.mk"
.include "../../x11/libXext/buildlink3.mk"
.include "../../x11/libXcursor/buildlink3.mk"
.include "../../x11/libXft/buildlink3.mk"
.include "../../x11/libXi/buildlink3.mk"
.include "../../x11/libXmu/buildlink3.mk"
.include "../../x11/libXrandr/buildlink3.mk"
.include "../../x11/libXrender/buildlink3.mk"
.include "../../x11/libxkbcommon/buildlink3.mk"
.endif


It does not include features.mk by itself, but by way of glu. The EGL
check was present, I only added DRI. This seems a nice grouping of the
X11 stuff that is not relevant for Darwin. Should I create a separate
section outside that just for DRI?


Alrighty then,

Thomas
-- 
Dr. Thomas Orgis
HPC @ Universität Hamburg