Jonathan Perkin <jperkin%joyent.com@localhost> writes:
> So I've written a quick patch to add a variable to pkg_install.conf,
> CHECK_OS_VERSION, which if set to "no" will skip the version checks
> and not print the warning. You can find the diff here:
>
> https://gist.github.com/jperkin/b8b98d0dd701270b4c6967280696bacd
>
> For those not familiar with this code, this is only for the kernel
> version comparison (i.e. uname -r), there are still always fatal
> warnings if either the OPSYS or MACHINE_ARCH do not match.
I think it's reasonable to skip the warning for systems that are more or
less similar, but I don't think we -- really anyone -- has a good reason
to skip it for installing 8 packages on 9.
So if this were limited to
For X1.Y1.Z1 and X2.Y2.Z2, skip warning if
X1 == X2 and Y1 != 99 and Y2 != 99, or
X1 == X2 and Y1 == Y2 == 99
then I am in favor of making it default behavior.
However since you are proposing an optional variable to skip the check,
which will not be enabled by default, I don't object to you committing
this.
Attachment:
signature.asc
Description: PGP signature