Re: [PATCH] Fix bootstrap on FreeBSD 12.1 (needs -lmd when linking libarchive statically)

[David Holland <dholland-pkgtech%netbsd.org@localhost>]

On Sun, Oct 18, 2020 at 03:15:48PM +0000, coypu%sdf.org@localhost wrote:
 > Hi all,
 > 
 > I tried my best to do this as properly as possible, but I have a feeling
 > that I'm not meeting the expected style for this file.
 > 
 > Any suggestions, or else I will commit it soon because bootstrap being
 > broken is bad.

Seems reasonable to me, except for one carp: STATIC_LIBARCHIVE_DEPENDS
sounds like it's something you should use like this:

foo: $(STATIC_LIBARCHIVE_DEPENDS)
        $(CC) $(LDFLAGS) $(OBJS) $(STATIC_LIBARCHIVE) $(LIBS) -o foo

and since that's not what it is, it might be better to use some other
name. STATIC_LIBARCHIVE_MORELIBS comes to mind as one possible
choice...

-- 
David A. Holland
dholland%netbsd.org@localhost