tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: [PATCH] Fix bootstrap on FreeBSD 12.1 (needs -lmd when linking libarchive statically)

On Sun, Oct 18, 2020 at 03:15:48PM +0000, wrote:
 > Hi all,
 > I tried my best to do this as properly as possible, but I have a feeling
 > that I'm not meeting the expected style for this file.
 > Any suggestions, or else I will commit it soon because bootstrap being
 > broken is bad.

Seems reasonable to me, except for one carp: STATIC_LIBARCHIVE_DEPENDS
sounds like it's something you should use like this:

        $(CC) $(LDFLAGS) $(OBJS) $(STATIC_LIBARCHIVE) $(LIBS) -o foo

and since that's not what it is, it might be better to use some other
name. STATIC_LIBARCHIVE_MORELIBS comes to mind as one possible

David A. Holland

Home | Main Index | Thread Index | Old Index