tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: [PATCH] pkg_install: fix stage in verbose log message



On 2020-05-25, Michael Forney <mforney%mforney.org@localhost> wrote:
> Currently, it always shows PRE-INSTALL, even if it is running with
> POST-INSTALL.
> ---
>  pkgtools/pkg_install/files/add/perform.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

I'd like to submit this change. Is this something that should come
with a version bump in files/lib/version.h? How about
files/configure.ac? Looking through history, I see that sometimes
version.h is changed, sometimes it isn't, and the version in
configure.ac is rarely changed (recently there was an 11 year bump).

> diff --git a/pkgtools/pkg_install/files/add/perform.c
> b/pkgtools/pkg_install/files/add/perform.c
> index c0111998c23..f68b04cc3dc 100644
> --- a/pkgtools/pkg_install/files/add/perform.c
> +++ b/pkgtools/pkg_install/files/add/perform.c
> @@ -979,7 +979,8 @@ run_install_script(struct pkg_task *pkg, const char
> *argument)
>  	setenv(PKG_REFCOUNT_DBDIR_VNAME, config_pkg_refcount_dbdir, 1);
>
>  	if (Verbose)
> -		printf("Running install with PRE-INSTALL for %s.\n", pkg->pkgname);
> +		printf("Running install with %s for %s.\n", argument,
> +		    pkg->pkgname);
>  	if (Fake)
>  		return 0;
>
> --
> 2.26.2


Home | Main Index | Thread Index | Old Index