tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: enabling WebRTC by default in firefox

Thomas Klausner <> wrote:
>On Fri, May 22, 2020 at 08:42:55PM +0100, Robert Swindells wrote:
>> >If you attach / commit what you have to wip, I can hack at it from here.
>> <>
>> I have tested it on NetBSD-current using firefox, not just built the
>> package.
>I've added this to wip/libv4l and fixed some minor issues, but it
>doesn't build because of SSP for me:
>  CC       v4l1compat_la-v4l1compat.lo
>v4l1compat.c:115:23: error: redefinition of 'read'
> LIBV4L_PUBLIC ssize_t read(int fd, void *buffer, size_t n)
>                       ^~~~
>In file included from /usr/include/ssp/stdio.h:34,
>                 from /usr/include/stdio.h:602,
>                 from ../../lib/include/libv4l1.h:26,
>                 from v4l1compat.c:31:
>/usr/include/ssp/unistd.h:39:1: note: previous definition of 'read' was here
> __ssp_redirect0(ssize_t, read, (int __fd, void *__buf, size_t __len), \
> ^~~~~~~~~~~~~~~
>gmake[3]: *** [Makefile:657: v4l1compat_la-v4l1compat.lo] Error 1
>The old package had workarounds in patch-af and patch-am that just
>removed that function. Not sure if that breaks any functionality

Removing the local replacement of read() looks wrong to me.

The syscall wrappers are needed to make the package work.

Is there a way of disabling SSP just for this package ? I have it
disabled in mk.conf so didn't see this error.

Home | Main Index | Thread Index | Old Index