[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: PKG_DEVELOPER=yes [Re: CVS commit: pkgsrc/lang/zig]
On Thu, May 14, 2020 at 07:42:20PM +0100, Jonathan Perkin wrote:
> * On 2020-05-14 at 18:30 BST, Nia Alarie wrote:
> > Module Name: pkgsrc
> > Committed By: nia
> > Date: Thu May 14 17:30:50 UTC 2020
> > Modified Files:
> > pkgsrc/lang/zig: Makefile
> > Log Message:
> > zig: Installs a script that requires bash.
> > Replace the interpreter so this doesn't fail with PKG_DEVELOPER.
> > Please set PKG_DEVELOPER=yes to detect problems like this!
> We should just set this by default. There's absolutely no excuses for
> packages to be failing these basic checks.
> Maybe we move all of the current tests outside of the PKG_DEVELOPER
> checks, and instead make =yes to mean much more stringent additional
> checks, like some of the stuff Roland is working on, ensure pkglint
> runs clean, and turning on some additional CHECK_WRKREF etc.
I'd rather a check be moved into default users than change the default
on PKG_DEVELOPER (this was the interpretation taken by someone who had
committed PKG_DEVELOPER=yes as a default).
Without a distinct PKG_DEVELOPER, it'd be harder to introduce new
checks in a gradual, non-impactful manner.
Main Index |
Thread Index |