Re: EXTRACT_USING improvements: a concrete proposal

[Jonathan Perkin <jperkin%joyent.com@localhost>]

* On 2020-03-13 at 22:59 GMT, Jonathan Perkin wrote:

> * On 2020-03-13 at 21:55 GMT, Greg Troxel wrote:
> 
> > Jonathan Perkin <jperkin%joyent.com@localhost> writes:
> > 
> > > * On 2020-03-11 at 22:11 GMT, Roland Illig wrote:
> > >
> > >> On 11.03.2020 18:00, Greg Troxel wrote:
> > >> > I think this is ready to commit, and that if there are problems they
> > >> > will be easy to spot, not mysterious.
> > >> 
> > >> Looks good to me. I'm always in favor of cleaning up the wrong
> > >> documentation.
> > >
> > > FWIW (to both of you), checkperms + EXTRACT_USING is currently causing
> > > complete build failure on SunOS:
> > >
> > >   https://us-east.manta.joyent.com/pkgsrc/public/reports/trunk/tools/20200313.2102/meta/report.html
> > >
> > > It's not clear to me yet what's going on, EXTRACT_USING=gtar fixes it,
> > > but is that going to cause circular dependencies?
> > 
> > Multiple thoughts
> > 
> >   I don't understand why my changes would contribute to this, because
> >   the value of EXTRACT_USING on SunOS should continue to be nbtar, just
> >   as it was before.  And that should continue to point to base gtar.  It
> >   is merely that the redundant setting in defaults.mk is gone, except
> >   for NetBSD.
> 
> Yeh it's not your change, just coincidental timing.

Actually, as soon as I sent this I realised that it is in-fact your
change that is causing this.  The setting in mk/extract is set too
late for the infrastructure, as shown trivially here:

  $ bmake show-var VARNAME=EXTRACT_USING
  nbtar

  $ bmake
  [...]
  ===> Extracting for checkperms-1.12
  tar: pax_global_header: typeflag 'g' not recognized, converting to regular file
  *** Error code 1

  $ bmake clean
  $ bmake EXTRACT_USING=nbtar
  [...]
  ===> Extracting for checkperms-1.12
  echo ".PHONY: checkperms.cat1" >> /home/pbulk/build/sysutils/checkperms/work/checkperms-1.12/Makefile

Can you take another look and ensure that the default is set prior to
being used by all of the mk/extract logic?

-- 
Jonathan Perkin  -  Joyent, Inc.  -  www.joyent.com