Re: CVS commit: pkgsrc/databases/mongodb

[Greg Troxel <gdt%lexort.com@localhost>]

"Adam Ciarcinski" <adam%netbsd.org@localhost> writes:

> Module Name:	pkgsrc
> Committed By:	adam
> Date:		Fri Jun 28 12:57:28 UTC 2019
>
> Modified Files:
> 	pkgsrc/databases/mongodb: Makefile
>
> Log Message:
> mongodb: remove unused comment
>
>
> @@ -24,7 +24,6 @@ BUILD_DEPENDS+=	${PYPKGPREFIX}-yaml-[0-9
>  NO_CONFIGURE=	yes
>  # https://github.com/mongodb/mongo/blob/master/docs/building.md
>  USE_LANGUAGES=	c99 c++17
> -# USE_LANGUAGES+=	c11
>  GCC_REQD+=	8
>  
>  USE_TOOLS+=	pkg-config

Please put this back; I'll do so if you don't.

1) This is a revert of something I added, and there has been no
discussion or even private mail.  So it's not ok, regardless of the
merits.

2) mongodb in the SConstruct says it needs c11.  It's only in a comment
because that seems to lead to build problems.  One can argue that there
should be a comment in the Makefile saying this, rather than the commit
message.

https://github.com/mongodb/mongo/blob/master/SConstruct#L2446