Re: Prevent surprising build failures involving symlinks

[Jonathan Perkin <jperkin%joyent.com@localhost>]

* On 2019-05-01 at 11:40 BST, Roland Illig wrote:

> I've started a bulk build, and several packages failed surprisingly.
> They didn't find their dependent libraries or include files, and some
> other just didn't install any files. It took me quite a while to track
> down the actual cause.
> 
> My actual setup is:
> 
>     /home/pbulk -> /scratch/pbulk
> 
>     sh /home/pbulk/pkgsrc/bootstrap/bootstrap --unprivileged
> 
> To prevent others from experiencing the same problem, I'd like to apply
> the attached patch to the bootstrap. Any thoughts? Am I really the first
> one to experience this?

There's no point having ALLOW_SYMLINK_PATHS, it simply won't work at
all, and providing even the faintest hope that it might is harmful.

I approve having a simple check or die in bootstrap though.

-- 
Jonathan Perkin  -  Joyent, Inc.  -  www.joyent.com