tech-pkg archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: lang/go14: Import OpenBSD 6.4 fix from ports



On Thu, Apr 11, 2019 at 09:33:41AM -0400, Sijmen J. Mulder wrote:
> OpenBSD 6.4 requires stack pages to be mapped with MAP_STACK. Golang
> added support in 1.11 [1] but 1.4, which we need for bootstrapping, does
> not support it and consequently segfaults in go_bootstrap.
> 
> Patches imported from the OpenBSD ports tree since the 1.11 changes
> don't apply to 1.4.
> 
> [1] https://github.com/golang/go/issues/26142
> 
> Sijmen J. Mulder

Committed. but notice that you were modifying non openbsd specific
files, so that would have broken non-openbsd.

I used #ifdef GOOS_openbsd, which seems to be valid. It's not ideal, but
it is for bootstrap, and perfect is the enemy of good enough.


Home | Main Index | Thread Index | Old Index