Re: CVS commit: pkgsrc/devel/geany

["David H. Gutteridge" <david%gutteridge.ca@localhost>]

On Thu, 2019-04-04 at 15:52 +0200, Joerg Sonnenberger wrote:
> On Thu, Apr 04, 2019 at 06:09:54AM +0000, maya%netbsd.org@localhost wrote:
> > On Thu, Apr 04, 2019 at 04:13:51AM +0000, David H. Gutteridge wrote:
> > > Module Name:	pkgsrc
> > > Committed By:	gutteridge
> > > Date:		Thu Apr  4 04:13:51 UTC 2019
> > > 
> > > Modified Files:
> > > 	pkgsrc/devel/geany: Makefile options.mk
> > > 
> > > Log Message:
> > > geany: note explicit dependency on adwaita-icon-theme
> > > 
> > > If GTK3 is selected (now the default), we must explicitly depend on
> > > adwaita-icon-theme, otherwise various fundamental toolbar icons will be
> > > missing (unless, of course, another package has already installed it,
> > > which is why I didn't notice before). Bump PKGREVISION to note this
> > > fix.
> > > 
> > 
> > I think GTK3 should depend on adwaita-icon-theme.
> > It's not specific to geany that it expects its existence, it is all of
> > gtk3.
> 
> Except it can't because the icon set depends on GTK3 itself.

Yes, this discussion came up a few years ago, in PR 49494. GTK3 was
switched to depend on adwaita, and then was reverted back later the
same day. (With my update, I was following the general pattern I saw in
other packages.)

Regards,

Dave