Re: re-add libblkid dependency on libuuid

[Benny Siegert <bsiegert%gmail.com@localhost>]

+Jonathan Perkin

On Sun, Mar 31, 2019 at 12:35 PM Benny Siegert <bsiegert%gmail.com@localhost> wrote:
>
> Hi!
>
> I would like to ask permission for the following change during the freeze:
>
> Index: devel/libblkid/Makefile
> ===================================================================
> RCS file: /cvsroot/pkgsrc/devel/libblkid/Makefile,v
> retrieving revision 1.4
> diff -u -r1.4 Makefile
> --- devel/libblkid/Makefile     8 Dec 2017 08:03:35 -0000       1.4
> +++ devel/libblkid/Makefile     31 Mar 2019 10:35:35 -0000
> @@ -10,5 +10,5 @@
>  CONFIGURE_ARGS+=       --enable-libblkid
>  PKGCONFIG_OVERRIDE+=   libblkid/blkid.pc.in
>
> -#.include "../../devel/libuuid/buildlink3.mk"
> +.include "../../devel/libuuid/buildlink3.mk"
>  .include "../../mk/bsd.pkg.mk"
>
> This is to address the build failure seen in
> https://us-east.manta.joyent.com/pkgsrc/public/reports/Linux/ubuntu14.04/trunk/x86_64/20190331.0003//hal-0.5.14nb21/configure.log
>
> The last update commented out the libuuid dependency in Makefile but
> not in buildlink3.mk. No matter if the dependency is required or not,
> this is inconsistent and wrong.
>
> Given that blkid.pc contains "Requires.private: uuid", it should be a
> dependency.
>
> --
> Benny



-- 
Benny