Re: wip/cliqz: Request for review

[Santhosh Raju <santhosh.raju%gmail.com@localhost>]

On Thu, Jan 17, 2019 at 8:36 PM Santhosh Raju <santhosh.raju%gmail.com@localhost> wrote:
>
> On Thu, Jan 17, 2019 at 3:34 AM Roland Illig <roland.illig%gmx.de@localhost> wrote:
> >
> > I don't like bsdtar to be used in the do-install target. Pkglint already
> > warns about using ${CP} and pax -pe in the *-install targets, but it
> > doesn't know about bsdtar yet. The problem is that when the package is
> > installed as root, the owner/group of the files is set to the
> > information from the archive. The owner/group of the files should always
> > be 0/0, or UNPRIVILEGED_USER for unprivileged pkgsrc builds.
> >
>
> I see the issue with usage of bsdtar, what would be the suggested
> solution for this?
>

After going through my previous attempts, I rewrote the bsdtar section
with a pax -wr in the do-install section.

       cd ${WRKSRC}/obj/dist/cliqz && \
               ${PAX} -wr * ${DESTDIR}${PREFIX}/lib/cliqz && \
               ${CHOWN} -R ${ROOT_USER}:${ROOT_GROUP} ${DESTDIR}${PREFIX}/lib/*

It no longer does an uncompress process on the archive, but copies the
files from the build's obj directory output to the respective binary
location for pkgsrc.

rillig@, let me know if pax -wr is fine to use, since it has been used
in many packages to copy build's obj directory output to the
respective binary location for pkgsrc.

The changes have been pushed to pkgsrc-wip.I believe I have addressed
and fixed all the issues that were mentioned in the original post and
fixed them. Also found and fixed some minor bugs in the meantime.

rillig@ / leot@ , let me know if this looks good and if anything else
is blocking it from putting it into pkgsrc-current.

P.S: Apologies for the delay in replies, real life has been keeping me busy.

Regards
Santhosh