Re: osx mpv and swift

[Leonardo Taccari <leot%NetBSD.org@localhost>]

Hello Chuck,

Chuck Cranor writes:
> [...]
>     If I add "WAF_CONFIGURE_ARGS+=--disable-swift" then mpv compiles
> and links OK, but the video does not display -- I just get a white
> box with no video in it (audio is OK).   So that's not so great :(
>
> [...]
>
> They've clearly been changing the "--vo" options, as I have an
> older OSX system with "mpv-0.27.2nb2" that uses a "--vo opengl"
> ("opengl         : Extended OpenGL Renderer") for its video by
> default and that works fine.
>
>
> so maybe "mpv-0.29.1nb4" needs this swift stuff to link to
> in order make "--vo libmpv" work?   and "--vo gpu" doesn't
> work, so we need "--vo libmpv" to work.   but something in
> pkgsrc is preventing the link to swift from working?
>
>
> I'm attaching config logs for "WAF_CONFIGURE_ARGS+=--disable-swift"
> (config.log.noswift.gz) and from before I added it when the link
> fails (config.log.swift.gz).
>
> [...]

Thanks for checking that and and for sharing all the logs!

I've tried to look at the config.log and re-read the mpv changelogs.

It seems that with `--disable-swift' opengl-cb support is disabled
and indeed according the changelog it seems this was introduced in
0.29.0.

That's probably not completely related but...
Adam, do you remember why in multimedia/mpv/Makefile,-r1.16 Darwin
started to be handled differently, i.e.:

 | +
 | +.include "../../mk/bsd.prefs.mk"
 | +.if ${OPSYS} != "Darwin"
 | +.include "../../graphics/MesaLib/buildlink3.mk"
 | +.include "../../x11/libXinerama/buildlink3.mk"
 | +.include "../../x11/libXv/buildlink3.mk"
 | +.include "../../x11/libXxf86vm/buildlink3.mk"
 | +.include "../../mk/oss.buildlink3.mk"
 | +.endif
 | +

(Previously all bl3 were included unconditionally.)


Thank you!